database: Alter teams.org_id column to be not null
#10572
Conversation
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
non-null-org-id
branch
4 times, most recently
from
d8daac5 to
59252a1
Compare
eth3lbert
left a comment
eth3lbert
left a comment
There was a problem hiding this comment.
The migration SQL looks good to me.
Looking at just the migration script, this seems like an irreversible change that could result in data loss. We probably won't need to revert it, but I'm wondering if there's a good way to undo this type of irreversible migration, including the data?
if it's necessary to restore it, we have the original data in the current database dump and can restore it from there. |
eth3lbert
left a comment
eth3lbert
left a comment
There was a problem hiding this comment.
With a backup, I don't see a problem with this.
Turbo87
force-pushed
the
non-null-org-id
branch
from
59252a1 to
3930983
Compare
Out of the roughly 1100 teams in our database only 10 have `org_id: NULL`. These teams belong to GitHub organizations that don't exist anymore, so the corresponding teams are essentially useless. See rust-lang#2796 (comment) for more context. Since the nullability of the column makes our code more complicated than it needs to be, this commit proposes to remove these teams and turn the column into a `not null` column.
Turbo87
force-pushed
the
non-null-org-id
branch
from
3930983 to
f7f0e23
Compare
2 participants
Out of the roughly 1100 teams in our database only 10 have
org_id: NULL. These teams belong to GitHub organizations that don't exist anymore, so the corresponding teams are essentially useless. See #2796 (comment) for more context.Since the nullability of the column makes our code more complicated than it needs to be, this commit proposes to remove these teams and turn the column into a
not nullcolumn.